Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip if there are no new commits in pre-release re runs #234

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Skip if there are no new commits in pre-release re runs #234

merged 1 commit into from
Jan 4, 2023

Conversation

sbe-arg
Copy link
Collaborator

@sbe-arg sbe-arg commented Jan 4, 2023

We do this check in normal runs but we are not contemplating action re runs of pre-releases, this solves it.

Not the best approach but is not doing any refactor of existing code

@sbe-arg sbe-arg requested a review from sammcj January 4, 2023 08:12
@sbe-arg sbe-arg mentioned this pull request Jan 4, 2023
Closed
@sbe-arg sbe-arg changed the title Skip if there are no new commits in prerelease re runs Skip if there are no new commits in pre-release re runs Jan 4, 2023
sammcj
sammcj reviewed Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@sammcj sammcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe enough I think!

@sbe-arg sbe-arg merged commit 39d8e88 into master Jan 4, 2023
@sbe-arg sbe-arg deleted the pre_tag-skips branch January 4, 2023 08:26
@druskus20 druskus20 mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammcj sammcj sammcj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbe-arg @sammcj