url: improve isURL detection

PR-URL: nodejs#47886 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
anonrig · Jun 5, 2023 · f1eaa85 · f1eaa85
1 parent 0ec5262
commit f1eaa85
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -571,11 +571,13 @@ ObjectDefineProperties(URLSearchParams.prototype, {
  * We use `href` and `protocol` as they are the only properties that are
  * easy to retrieve and calculate due to the lazy nature of the getters.
  *
+ * We check for auth attribute to distinguish legacy url instance with
+ * WHATWG URL instance.
  * @param {*} self
  * @returns {self is URL}
  */
 function isURL(self) {
-  return Boolean(self?.href && self.protocol);
+  return Boolean(self?.href && self.protocol && self.auth === undefined);
 }
 
 class URL {

diff --git a/test/parallel/test-url-is-url.js b/test/parallel/test-url-is-url.js
@@ -0,0 +1,11 @@
+// Flags: --expose-internals
+'use strict';
+
+require('../common');
+
+const { URL, parse } = require('url');
+const assert = require('assert');
+const { isURL } = require('internal/url');
+
+assert.strictEqual(isURL(new URL('https://www.nodejs.org')), true);
+assert.strictEqual(isURL(parse('https://www.nodejs.org')), false);