Bridge Pool CLI tests #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/test-bridge-pool-cli
…thereum bridge pool
Co-authored-by: Tiago Carvalho <[email protected]>
Co-authored-by: Tiago Carvalho <[email protected]>
This reverts commit 0ac0bc1.
…enforced Ensure minimum confirmations are enforced for pending Ethereum events
Changed the bytes passed into merkle proof to be references
sug0
reviewed
Dec 6, 2022
| if pool_contents.is_empty() { | ||
| println!("Bridge pool is empty."); | ||
| } else { | ||
| println!("Bridge pool contents: "); |
There was a problem hiding this comment.
Suggested change
| println!("Bridge pool contents: "); | |
| print!("Bridge pool contents: "); |
nit: maybe this is the desired output here? Bridge pool contents: { ...
There was a problem hiding this comment.
This I'm not sure about until I see it on the screen. Will get back to it when I have time.
There was a problem hiding this comment.
It made the whole thing a json payload, which is what I really wanted anyway.
Co-authored-by: Tiago Carvalho <[email protected]>
Co-authored-by: Tiago Carvalho <[email protected]>
Co-authored-by: Tiago Carvalho <[email protected]>
Co-authored-by: Tiago Carvalho <[email protected]>
…/namada into bat/ethbridge/test-bridge-pool-cli
james-chf
suggested changes
Dec 6, 2022
james-chf
approved these changes
Dec 6, 2022
sug0
approved these changes
Dec 7, 2022
Co-authored-by: James <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds E2E tests for the bridge pool cli. The test added checks that a transfer can be submitted to the pool and that when querying the pool, the submitted transfer is present.
Since the logic for signing bridge pool roots is not in place yet, a test for constructing proofs will be a later PR.