Add more logging around vote extensions #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-chf
force-pushed
the
james/ethbridge/fix-e2e
branch
from
a019f29 to
c92615c
Compare
james-chf
force-pushed
the
james/ethbridge/fix-e2e
branch
from
c92615c to
1bd7f16
Compare
|
pls update wasm |
james-chf
force-pushed
the
james/ethbridge/fix-e2e
branch
from
58f5b39 to
d005764
Compare
|
Having issues with the e.g. log from a validator in the |
james-chf
changed the title
namadac tx argumentseth-bridge-integration
james-chf
changed the title
eth-bridge-integrationeth-bridge-integration
sug0
approved these changes
Nov 10, 2022
batconjurer
requested changes
Nov 11, 2022
Merged
This reverts commit 1bd7f16.
* eth-bridge-integration: Update TODO [fix]: Changed some xan to nam, fixed some arg strings in e2e tests Update tests/src/native_vp/eth_bridge_pool.rs Update wasm/wasm_source/src/tx_bridge_pool.rs [ci] wasm checksums update Change vec -> set impl utils::GetVoters for HashSet<EthMsgUpdate> Add test_get_votes_for_events_multiple_signatures_same_validator Remove duplicate ChangedKeys type, fix imports make fmt Add a test that conversion does in fact dedupe Remove duplicate tests Remove unused import Simplify code Move dedupe fn to transaction module Remove TODO Add dedupe tests Split out a dedupe fn Do vote deduping when we convert from MultiSignedEthEvent Remove no longer necessary deduping from apply_update Add changelog Reorder sccache step Update wasm image Remove duplicate @ [feat]: Added tooling for testing wasms and vps. Adjusted the bridge pool tx wasm and added test
james-chf
changed the title
eth-bridge-integration
|
pls update wasm |
|
This PR is now just adding logging to help with debugging #767 (which is causing e2e CI to fail) |
batconjurer
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more logging to help with debugging #767 when it occurs in CI in the future.