Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require_latest_height check should skip for requests with height 0 #752

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

james-chf
Copy link
Contributor

Ported from fbfc105 in eth-bridge-integration

This was necessary to fix to get a test in eth-bridge-integration to pass (test_bridge_pool_updates)

--- STDOUT:                             namada ledger::queries::shell::test::test_bridge_pool_updates ---

running 1 test
test ledger::queries::shell::test::test_bridge_pool_updates ... FAILED

failures:

failures:
    ledger::queries::shell::test::test_bridge_pool_updates

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 207 filtered out; finished in 0.01s


--- STDERR:                             namada ledger::queries::shell::test::test_bridge_pool_updates ---
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: "This query doesn't support arbitrary block heights, only the latest committed block height ('0' can be used as a special value that means the latest block height)" }', shared/src/ledger/queries/shell.rs:634:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@james-chf james-chf force-pushed the james/mainline/fix-require-latest-height branch from 8e0a1c7 to df84dee Compare November 7, 2022 15:49
@james-chf james-chf marked this pull request as ready for review November 7, 2022 18:56
@juped juped merged commit 1e4dd41 into main Nov 15, 2022
@juped juped deleted the james/mainline/fix-require-latest-height branch November 15, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants