-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoS: lazy map epoched data #740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
tomas+brent/lazy-map-epoched
branch
3 times, most recently
from
November 14, 2022 18:37
f3d3bab
to
8cc15c0
Compare
brentstone
force-pushed
the
tomas+brent/lazy-map-epoched
branch
2 times, most recently
from
November 24, 2022 16:24
8b48db9
to
e122a3a
Compare
brentstone
force-pushed
the
tomas+brent/lazy-map-epoched
branch
2 times, most recently
from
December 1, 2022 13:31
050a7e0
to
a6401cd
Compare
tzemanovic
force-pushed
the
tomas+brent/lazy-map-epoched
branch
2 times, most recently
from
December 5, 2022 12:10
e741e57
to
d16f854
Compare
brentstone
force-pushed
the
tomas+brent/lazy-map-epoched
branch
3 times, most recently
from
December 9, 2022 13:45
f92a3bd
to
affbf70
Compare
brentstone
added a commit
that referenced
this pull request
Dec 13, 2022
Merged
tzemanovic
force-pushed
the
tomas+brent/lazy-map-epoched
branch
3 times, most recently
from
December 15, 2022 18:03
c413b3d
to
3c1f071
Compare
brentstone
force-pushed
the
tomas+brent/lazy-map-epoched
branch
from
December 16, 2022 21:57
c692ac7
to
a8ca01e
Compare
brentstone
force-pushed
the
tomas+brent/lazy-map-epoched
branch
from
December 27, 2022 02:19
e623fcc
to
814dc42
Compare
31 tasks
This was referenced Jan 5, 2023
Closed
This was referenced Jan 13, 2023
brentstone
force-pushed
the
tomas+brent/lazy-map-epoched
branch
from
January 13, 2023 22:41
814dc42
to
924a7d8
Compare
brentstone
force-pushed
the
tomas+brent/lazy-map-epoched
branch
from
February 3, 2023 17:19
86e9058
to
d45e9d0
Compare
brentstone
force-pushed
the
tomas+brent/lazy-map-epoched
branch
from
February 3, 2023 17:59
2e454e5
to
328b335
Compare
brentstone
previously approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Feb 7, 2023
This was referenced Feb 28, 2023
Merged
bengtlofgren
pushed a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently based on #1108.
The main issue this closes is #16, also closes #366, fix #43, fix #157, fix #13, fix #15, fix #158 ("validator total deltas" is just "validator stake" now), fix #787.
We also added a new
client delegations
query command.There are 2 little change in the PoS VP RPC - 665f1be#diff-cc52d1a0ab349c3059b5b4b06cc705b47761c974a8b69d96ebc6d03cfd63d30e:
validator_stake
now returnsOption<token::Amount>
instead of justtoken::Amount
and returnsNone
iff the given address doesn't belong to a validator. Note that it will still returnSome(0)
when the address is a validator, but without any stake.bond_amount
is being replaced withbond_with_slashing
As this PR is already pretty large and there isn't anything of substance that could be split out from it, we have for the time removed most of the PoS VP validation together and disabled its test as it's not essential for security in combination with tx whitelisting and authorization is checked by other VPs (vp_implicit, vp_validator, vp_user) which have been updated (with added test cases).