-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridge pool cli #729
Bridge pool cli #729
Conversation
…/ethbridge/eth-bridge-vp-escrow-nam
…-bridge-vp-escrow-nam
…/ethbridge/eth-bridge-vp-escrow-nam
…ridge/eth-bridge-vp-escrow-nam
…ng and a couple of small todos
…/ethbridge/bridge-pool-cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no relaying happening yet, right? couldn't these sub-commands still be a part of namadac
?
also, we should hold off on merging until #723 is in eth-bridge-integration
Co-authored-by: Tiago Carvalho <[email protected]>
Yeah, it could be part of the client, but I'm imagining in the future when we want to craft ethereum txs and calculate gas prices vs fees and all that shit, this will all be in this other binary. It was also a nicer ux. |
Although submitting to the pool does probably make more sense as a client command. |
need rebasing against 0.9.0 I guess |
I'll wait til after rebase on 0.9.0 to review, since the client side RPC logic changed in that release |
I haven't looked why but running the
|
I added methods to look up addresses from the wallet, but it looks like I messed up how it looks in the ui. |
Bad copy pasta. Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This PR partially closes #425. It depends on #715. It sets up CLI commands for the following:
It also generates a new binary,
namadar
which can handle these tasks. Eventually, this binary should become a more robust relayer. It refactors the queries in the shell a bit for better UX.This is not covered by tests yet as this PR is large enough. The wasm code needs to be updated and then we can test. That will be the next PR.