Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: change default folder to .namada #631

Closed
wants to merge 3 commits into from

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Oct 18, 2022

Lets not merge this until we have fixed our internal tools

@Fraccaman Fraccaman requested a review from tzemanovic October 18, 2022 10:03
@Fraccaman Fraccaman force-pushed the fraccaman/rename-default-folder branch from 5727f52 to 8ed459a Compare October 18, 2022 11:00
@Fraccaman Fraccaman force-pushed the fraccaman/rename-default-folder branch from 8ed459a to 30fba16 Compare October 18, 2022 11:00
@juped juped added this to the v0.9.0 milestone Oct 18, 2022
@juped
Copy link
Member

juped commented Oct 18, 2022

holding off on draft tests

@@ -28,7 +28,7 @@ WORKDIR /app
RUN git clone -b v0.1.1-abcipp --single-branch https://github.com/heliaxdev/tendermint.git && cd tendermint && make build

FROM debian:bullseye-slim AS runtime
ENV ANOMA_BASE_DIR=/.anoma
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's a BASE_DIR not a BASE_NADIR

Copy link
Contributor

@bengtlofgren bengtlofgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the help of Tomas ofc

@tzemanovic tzemanovic modified the milestones: v0.9.0, v0.10.0 Nov 2, 2022
@tzemanovic
Copy link
Member

I think we can maybe close this and apply all the breaking changes at once in #794

@tzemanovic
Copy link
Member

closed in favor of #794

@tzemanovic tzemanovic closed this Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants