Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multitoken transfer and query PR#359 for eth-bridge-integration #428

Merged

Conversation

james-chf
Copy link
Contributor

@james-chf james-chf commented Sep 2, 2022

This PR is equivalent to #359 (i.e. issue #132) but retargeting the eth-bridge-integration branch as a base, so that we can use it there faster, as this functionality is needed by #329 (i.e. issue #427)

@james-chf
Copy link
Contributor Author

pls update wasm

1 similar comment
@james-chf
Copy link
Contributor Author

pls update wasm

@james-chf james-chf force-pushed the james/ethbridge/transpose-yuji-multitoken branch from 95be6c7 to df76c3c Compare September 2, 2022 12:00
@james-chf
Copy link
Contributor Author

pls update wasm

@james-chf james-chf force-pushed the james/ethbridge/transpose-yuji-multitoken branch from fcb473e to fe95e80 Compare September 2, 2022 12:46
@james-chf james-chf marked this pull request as ready for review September 2, 2022 13:10
@james-chf
Copy link
Contributor Author

james-chf commented Sep 2, 2022

cc thanks @yito88 (I can't add you as reviewer)

Copy link
Member

@batconjurer batconjurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tinies, but otherwise looks good

vm_env/src/token.rs Outdated Show resolved Hide resolved
Co-authored-by: Jacob Turner <[email protected]>
@james-chf james-chf force-pushed the james/ethbridge/transpose-yuji-multitoken branch from d15e769 to bf9a096 Compare September 5, 2022 08:30
@james-chf
Copy link
Contributor Author

pls update wasm

@james-chf james-chf merged commit df0152c into eth-bridge-integration Sep 5, 2022
@james-chf james-chf deleted the james/ethbridge/transpose-yuji-multitoken branch September 5, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants