Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Osmosis shielded swaps #4133

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Dec 2, 2024

Describe your changes

Based on #4134

Implement client code to perform shielded swaps.

Diff: https://github.com/anoma/namada/compare/bat+tiago/feat/ibc-pfm-with-invalid-addrs..tiago/osmosis-swap-cli-over-v44

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

sug0 and others added 7 commits December 1, 2024 09:56
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 52.80289% with 261 lines in your changes missing coverage. Please review.

Project coverage is 74.48%. Comparing base (cc531ec) to head (28c5e3e).
Report is 79 commits behind head on main.

Files with missing lines Patch % Lines
crates/ibc/src/context/middlewares/pfm_mod.rs 52.63% 180 Missing ⚠️
crates/sdk/src/args.rs 0.00% 67 Missing ⚠️
crates/ibc/src/context/token_transfer.rs 63.63% 8 Missing ⚠️
crates/ibc/src/context/nft_transfer_mod.rs 33.33% 2 Missing ⚠️
crates/ibc/src/context/transfer_mod.rs 33.33% 2 Missing ⚠️
crates/ibc/src/lib.rs 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4133      +/-   ##
==========================================
- Coverage   74.58%   74.48%   -0.11%     
==========================================
  Files         341      343       +2     
  Lines      107484   108011     +527     
==========================================
+ Hits        80167    80450     +283     
- Misses      27317    27561     +244     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sug0 sug0 changed the title Susmosis... Implement Osmosis shielded swaps Dec 2, 2024
@sug0 sug0 force-pushed the tiago/osmosis-swap-cli-over-v44 branch from 6fa153d to 59b6d2b Compare December 2, 2024 16:32
@sug0 sug0 marked this pull request as draft December 2, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants