Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gen_localnet.py json exception #4089

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Nov 24, 2024

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@sug0 sug0 mentioned this pull request Nov 24, 2024
3 tasks
@sug0 sug0 added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 24, 2024
@sug0 sug0 requested a review from tzemanovic November 24, 2024 13:13
@sug0 sug0 added the testing label Nov 24, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (5bf522f) to head (2604264).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4089   +/-   ##
=======================================
  Coverage   74.58%   74.58%           
=======================================
  Files         341      341           
  Lines      107484   107484           
=======================================
  Hits        80166    80166           
  Misses      27318    27318           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sug0 sug0 requested a review from Fraccaman November 25, 2024 19:52
@tzemanovic tzemanovic added the backport-libs-0.46 Backport libraries to 0.46 maintenance branch label Nov 26, 2024
mergify bot added a commit that referenced this pull request Nov 26, 2024
@mergify mergify bot merged commit 7b7e59a into main Nov 26, 2024
23 of 24 checks passed
@mergify mergify bot deleted the tiago/gen-localnet-json-fix branch November 26, 2024 17:50
mergify bot added a commit that referenced this pull request Nov 28, 2024
Fix `gen_localnet.py` json exception (backport #4089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-libs-0.46 Backport libraries to 0.46 maintenance branch merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants