Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate validator metadata #4036

Merged
merged 6 commits into from
Nov 21, 2024
Merged

validate validator metadata #4036

merged 6 commits into from
Nov 21, 2024

Conversation

tzemanovic
Copy link
Member

Describe your changes

fixes #4033

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic added the breaking:consensus Consensus breaking change that requires a hard-fork label Nov 15, 2024
tzemanovic added a commit that referenced this pull request Nov 15, 2024
tzemanovic added a commit that referenced this pull request Nov 15, 2024
@tzemanovic tzemanovic force-pushed the tomas/validate-validator-metadata branch from 4c3b72a to 34b7aaa Compare November 15, 2024 12:33
@tzemanovic tzemanovic marked this pull request as ready for review November 15, 2024 12:33
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 18 lines in your changes missing coverage. Please review.

Project coverage is 74.56%. Comparing base (63eaf11) to head (1ab9f63).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
crates/proof_of_stake/src/types/mod.rs 68.57% 11 Missing ⚠️
crates/proof_of_stake/src/vp.rs 76.92% 3 Missing ⚠️
crates/apps_lib/src/config/genesis/transactions.rs 50.00% 2 Missing ⚠️
crates/proof_of_stake/src/error.rs 0.00% 1 Missing ⚠️
crates/proof_of_stake/src/storage.rs 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4036      +/-   ##
==========================================
+ Coverage   74.31%   74.56%   +0.25%     
==========================================
  Files         341      341              
  Lines      107401   107413      +12     
==========================================
+ Hits        79815    80097     +282     
+ Misses      27586    27316     -270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@brentstone brentstone added this to the v0.46.0 milestone Nov 18, 2024
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx so much!

@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 21, 2024
@tzemanovic tzemanovic force-pushed the tomas/validate-validator-metadata branch from 34b7aaa to 1ab9f63 Compare November 21, 2024 09:25
mergify bot added a commit that referenced this pull request Nov 21, 2024
mergify bot added a commit that referenced this pull request Nov 21, 2024
mergify bot added a commit that referenced this pull request Nov 21, 2024
@mergify mergify bot merged commit d0f62b0 into main Nov 21, 2024
24 of 25 checks passed
@mergify mergify bot deleted the tomas/validate-validator-metadata branch November 21, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:consensus Consensus breaking change that requires a hard-fork merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate validator metadata changes from on-chain tx
3 participants