Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IBC NFT unshielding #4027

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Fix IBC NFT unshielding #4027

merged 3 commits into from
Nov 20, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Nov 14, 2024

Describe your changes

closes #4025

  • IBC VP should check the unshielding transfer by enabling is_shielding
  • The packet data in IbcMsgNftTransfer is incomplete. We need to set the NFT data before MASP VP checking

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@yito88 yito88 added the IBC label Nov 14, 2024
@yito88 yito88 requested review from tzemanovic and grarco November 14, 2024 12:35
@tzemanovic
Copy link
Member

labelled with "breaking:protocol" due to a change in the native VP

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 42 lines in your changes missing coverage. Please review.

Project coverage is 74.05%. Comparing base (e768857) to head (68915eb).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
crates/ibc/src/lib.rs 12.50% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4027      +/-   ##
==========================================
- Coverage   74.09%   74.05%   -0.04%     
==========================================
  Files         341      341              
  Lines      107204   107249      +45     
==========================================
- Hits        79428    79426       -2     
- Misses      27776    27823      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yito88 yito88 mentioned this pull request Nov 14, 2024
3 tasks
@brentstone brentstone added this to the v0.46.0 milestone Nov 14, 2024
@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 20, 2024
mergify bot added a commit that referenced this pull request Nov 20, 2024
mergify bot added a commit that referenced this pull request Nov 20, 2024
@mergify mergify bot merged commit 8e18078 into main Nov 20, 2024
22 of 24 checks passed
@mergify mergify bot deleted the yuji/fix-ibc-nft-unshielding branch November 20, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking: protocol IBC merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unshielding NFT transfer via IBC failed
4 participants