-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the performance of the shielded sync ledger client #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
reviewed
Nov 12, 2024
sug0
force-pushed
the
tiago/ss-ledger-client-improvements
branch
from
November 12, 2024 14:36
605c1f5
to
1f85e3f
Compare
sug0
force-pushed
the
tiago/ss-ledger-client-improvements
branch
from
November 12, 2024 14:36
1f85e3f
to
b2332bf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4016 +/- ##
==========================================
- Coverage 73.92% 73.92% -0.01%
==========================================
Files 341 341
Lines 106467 106510 +43
==========================================
+ Hits 78709 78740 +31
- Misses 27758 27770 +12 ☔ View full report in Codecov by Sentry. |
grarco
approved these changes
Nov 12, 2024
sug0
added
the
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
label
Nov 12, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit b2332bf)
3 tasks
mergify bot
added a commit
that referenced
this pull request
Nov 12, 2024
Improve the performance of the shielded sync ledger client (backport #4016)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The shielded sync's ledger client continues to perform poorly, even after #3578. This PR introduces some optimizations to the ledger client, and improves its UX a bit.
fetch_shielded_transfers
now has a single semaphore point, at the top of the method, rather than two.In general, the indexer masp client still performs about 10x better than the ledger masp client, while fetching shielded txs.
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo