Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MASP sdk errors #4003

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Improve MASP sdk errors #4003

merged 2 commits into from
Nov 11, 2024

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Nov 7, 2024

Describe your changes

Improves MASP related SDK errors, namely insufficient balance errors.

image

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Sorry, something went wrong.

@sug0 sug0 added the UX label Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 45.55556% with 49 lines in your changes missing coverage. Please review.

Project coverage is 73.92%. Comparing base (86fd732) to head (1e741f4).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
crates/shielded_token/src/masp/shielded_wallet.rs 32.85% 47 Missing ⚠️
crates/shielded_token/src/masp.rs 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4003      +/-   ##
==========================================
+ Coverage   73.89%   73.92%   +0.03%     
==========================================
  Files         341      341              
  Lines      106463   106479      +16     
==========================================
+ Hits        78666    78712      +46     
+ Misses      27797    27767      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@sug0 sug0 added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 11, 2024
mergify bot added a commit that referenced this pull request Nov 11, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mergify mergify bot merged commit 732505c into main Nov 11, 2024
23 of 24 checks passed
@mergify mergify bot deleted the tiago/better-masp-balance-errors branch November 11, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking:SDK MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass SDK UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants