MASP rewards estimation #3974
MASP rewards estimation #3974
Conversation
batconjurer
force-pushed
the
bat/masp-reward-estimations
branch
from
542fb1a to
4c756bd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3974 +/- ##
==========================================
+ Coverage 73.95% 74.12% +0.16%
==========================================
Files 341 341
Lines 106442 107130 +688
==========================================
+ Hits 78718 79405 +687
- Misses 27724 27725 +1 ☔ View full report in Codecov by Sentry. |
| @@ -1397,6 +1416,27 @@ fn masp_incentives() -> Result<()> { | |||
| assert!(captured.result.is_ok()); | |||
| assert!(captured.contains("nam: 0.063")); | |||
|
|
|||
| // Assert the rewards estimate is a number higher than the actual rewards | |||
There was a problem hiding this comment.
what does this comment mean?
There was a problem hiding this comment.
Just a sanity check. The total amount of rewards issued for an asset should increase with each epoch. So estimations should reflect that.
There was a problem hiding this comment.
LGTM! Thx for all the tests. Just left a question, and can you look over my very small cleanup commit 16ddaf3 before tagging this PR with merge?
Looks good, thanks for fixing those! |
brentstone
added
the
merge
Describe your changes
Adds a cli command to estimate the amount of MASP rewards that will be accumulated by the next epoch.
This is done by applying the latest set of conversions for each asset again.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo