Fix up CI on eth-bridge-integration
#387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls update wasm |
james-chf
requested review from
batconjurer and
sug0
and removed request for
batconjurer
|
@james-chf seems like e2e tests are also broken here. I was looking into fixing them yesterday, but got nowhere 😬 |
|
should we try to fix them in this PR as well? |
I'd say not in this PR, we can merge these easy fixes but the e2e test fixing will be more involved (should probably open issues for them) |
|
If the changes from this PR are in #286 , then when that merges this PR can be closed |
phy-chain
pushed a commit
to phy-chain/namada
that referenced
this pull request
Mar 1, 2024
* docs: sdk usage * docs: improvements for the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick PR to fix up CI on
eth-bridge-integrationmake fmt