Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Murisi/integrate hw masp #3797

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Murisi/integrate hw masp #3797

wants to merge 14 commits into from

Commits on Nov 27, 2024

  1. Implemented MASP signing using the hardware wallet.

    @murisi
    murisi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    44c5f03 View commit details
    Browse the repository at this point in the history

  2. Factored out the logic for MASP hardware wallet signing.

    @murisi
    murisi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    5fd0281 View commit details
    Browse the repository at this point in the history

  3. Expand MASP hardware wallet support to other transaction types.

    @murisi
    murisi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    b78d8bf View commit details
    Browse the repository at this point in the history

  4. Separate the storage of shielded keys from their birthdays.

    @murisi
    murisi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    9e7c974 View commit details
    Browse the repository at this point in the history

  5. Never use the hardware wallet to sign the fee header alone. Always en… 

    …sure removal of MASP Builder data.
    @murisi
    murisi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    381531b View commit details
    Browse the repository at this point in the history

  6. Moved the shielded keys used in the integration tests into the localn… 

    …et wallet.
    @murisi
    murisi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    0ef7b66 View commit details
    Browse the repository at this point in the history

  7. Dont do a dry run if using a device in the MASP integration tests.

    @murisi
    murisi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    2d8c41c View commit details
    Browse the repository at this point in the history

  8. Always sign MASP Transactions before dumping because randomness param… 

    …eters cannot be reused. Fixed MASP integration tests depending on access to secret keys.
    @murisi
    murisi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    3e72fe1 View commit details
    Browse the repository at this point in the history

  9. test/e2e/masp: add support for testing with HW wallet

    @tzemanovic @murisi
    tzemanovic authored and murisi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    fd48de2 View commit details
    Browse the repository at this point in the history

  10. Sometimes use literals instead of aliases in the IBC tests.

    @murisi
    murisi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    bdd8e9f View commit details
    Browse the repository at this point in the history

  11. Make shielded balance checking more robust for IBC tests.

    @murisi
    murisi committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    706a143 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Adjust integration tests to work with both hardware and localnet gene… 

    …sis files.
    @murisi
    murisi committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e59aaf6 View commit details
    Browse the repository at this point in the history

  2. Make the the software wallet support the old Store format.

    @murisi
    murisi committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    2105731 View commit details
    Browse the repository at this point in the history

  3. Test that the transfer source now displays as a viewing key.

    @murisi
    murisi committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    79106c5 View commit details
    Browse the repository at this point in the history