draft: Validator eth secp keys #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* junkicide+tomas/pos-tx-tests: test: add seed for failed PoS VP test [ci skip] wasm checksums update pos/vp: remove redundant validity predicate storage key check doc fixed in proof_of_stake/ Update comments quick doc fix removed a deprecated function, spelling fixes clean up documentation tests/pos: add proptest-regressions file Changelog: add #462 wasm: test tx_withdraw wasm: tx_unbond tests PoS: fix Bonds data type and application of unbonding on it PoS: fix type s/OffsetUnboundingLen/OffsetUnbondingLen tests: reuse init_pos for native pos vp test tests: make native pos vp module public tests: add re-usable PoS initialization helper PoS: add PartialOrd, Ord, PartialEq and Eq for Epoched an EpochedDelta tests: expose native_vp test helpers shared/token: add arb_amount_ceiled testing strategy wasm: add tx_bond tests shared/token: add arb_amount testing strategy shared/key: add arb_common_keypair testing strategy
* tomas/refactor-pos-vp: changelog: add #318 pos: fix bond zero amount error msg pos/validation: refactor accumulation of changes
|
note: fn read_validator_eth_hot_key(
&self,
key: &Self::Address
) -> Option<Self::PublicKey>this method should return EDIT: solved here 0ef4072 |
This was referenced Sep 15, 2022
|
this is going to stay in draft for now - it's only partially finished, because some updates depend on other PoS changes that are not in eth-bridge-integration yet, but it unblocked the bridge dev itself |
|
@batconjurer @tzemanovic Is this PR still relevant? Should it be merged into the Ethereum bridge integration branch, perhaps? |
|
@cwgoes it's already in |
|
Closing this since it's stale. If we need commits from this then @batconjurer @sug0 can pick them into a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #254 and #318
This PR adds 2 required validator eth bridge secp256k1 keys - hot and cold. Hot key will be used for signing validator set updates and cross-chain transactions (done by the ledger) and cold key for bridge governance (done on-demand by validators).
to-do: