Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagates error from is_proposal_accepted #3700

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Aug 23, 2024

Describe your changes

Closes #3238.

I've reviewed the code for our native vps and removed the wrong calls to unwrap_or_default applied to results (those on options are fine).

⚠️ WARNING ⚠️
Pay attention to merging this PR cause it carries breaking changes that span multiple vps, including especially the governance one: so even in the context of the multi-stage deployment of mainnet this could cause problems.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.18%. Comparing base (2256e38) to head (6db4ceb).
Report is 10 commits behind head on main.

Files Patch % Lines
crates/governance/src/vp/pgf.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3700   +/-   ##
=======================================
  Coverage   61.17%   61.18%           
=======================================
  Files         315      315           
  Lines      103187   103183    -4     
=======================================
+ Hits        63129    63131    +2     
+ Misses      40058    40052    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco marked this pull request as ready for review August 23, 2024 16:45
@grarco grarco requested review from Fraccaman and sug0 August 23, 2024 17:24
Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks

@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 27, 2024
mergify bot added a commit that referenced this pull request Aug 27, 2024
@mergify mergify bot merged commit d97f76d into main Aug 27, 2024
23 of 34 checks passed
@mergify mergify bot deleted the grarco/fix-error-mishandling branch August 27, 2024 12:26
@grarco grarco mentioned this pull request Sep 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking: protocol merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle gas related errors in tx execution/validation pipeline
3 participants