Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support only a transparent address as a refund target #3646

Merged
merged 9 commits into from
Aug 20, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Aug 14, 2024

Describe your changes

Closes #3620
Closes #3619

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@yito88
Copy link
Member Author

yito88 commented Aug 14, 2024

hmm, wasm compilation error happened again on my Mac

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 34.28571% with 46 lines in your changes missing coverage. Please review.

Project coverage is 61.19%. Comparing base (80268fa) to head (8541049).
Report is 136 commits behind head on main.

Files Patch % Lines
crates/sdk/src/tx.rs 0.00% 30 Missing ⚠️
crates/ibc/src/context/nft_transfer.rs 41.66% 7 Missing ⚠️
crates/ibc/src/context/token_transfer.rs 66.66% 4 Missing ⚠️
crates/ibc/src/msg.rs 50.00% 3 Missing ⚠️
crates/ibc/src/lib.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3646   +/-   ##
=======================================
  Coverage   61.18%   61.19%           
=======================================
  Files         312      312           
  Lines      101384   101351   -33     
=======================================
- Hits        62033    62021   -12     
+ Misses      39351    39330   -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yito88 yito88 force-pushed the yuji/ibc-refund-transparent branch from bbcfc57 to db26e06 Compare August 16, 2024 11:31
@yito88 yito88 requested review from sug0 and grarco August 16, 2024 14:39
crates/sdk/src/tx.rs Outdated Show resolved Hide resolved
crates/ibc/src/lib.rs Outdated Show resolved Hide resolved
@yito88 yito88 requested a review from sug0 August 19, 2024 11:03
@cwgoes cwgoes added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 20, 2024
mergify bot added a commit that referenced this pull request Aug 20, 2024
@mergify mergify bot merged commit b7d2db3 into main Aug 20, 2024
20 of 21 checks passed
@mergify mergify bot deleted the yuji/ibc-refund-transparent branch August 20, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework shielded action refund Refund failed when IBC unshielded transfer failed
4 participants