-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove parallel gas #3615
Remove parallel gas #3615
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3615 +/- ##
==========================================
- Coverage 61.22% 61.22% -0.01%
==========================================
Files 312 312
Lines 101394 101374 -20
==========================================
- Hits 62083 62067 -16
+ Misses 39311 39307 -4 ☔ View full report in Codecov by Sentry. |
@@ -481,8 +481,6 @@ pub struct VpsResult { | |||
pub accepted_vps: BTreeSet<Address>, | |||
/// The addresses whose VPs rejected the transaction | |||
pub rejected_vps: BTreeSet<Address>, | |||
/// The total gas used by all the VPs | |||
pub gas_used: VpsGas, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed this because I believe it carries little information to the final user (since VpsResult
ends up being published in the tx result event) given that it only mentions the amount of gas used by vps without specifying the distribution across the different vps and inside each vp (compilation, execution, host Fns,...)
47402c4
to
83b1e33
Compare
Actually my changes to the |
83b1e33
to
13097bc
Compare
I rebased onto #3573 to update hermes |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. ⛓️ Depends-On RequirementsRequirement based on the presence of
|
ah, looks like there's still some issue with e2e test |
@yito88 pushed a commit that fixes it, we should be good now |
ah, I think we need it in the base PR - will add it there |
Hey @grarco, your pull request has been dequeued due to the following reason: CONFLICT_WITH_BASE_BRANCH. |
bc2ddf8
to
0c07a1b
Compare
Seems like another test is failing, I'll have a look |
Ok it just seems that this is test is a bit flaky and sometimes 3 retries are not enough |
Describe your changes
Closes #3587.
Depends-On: #3573
This PR removes the parallel gas dividers and the
VpsGas
type which isn't needed anymore. It also removes the gas used field fromVpsResult
.Checklist before merging
breaking::
labels