Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various misc improvements #3589

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Various misc improvements #3589

merged 5 commits into from
Aug 9, 2024

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Aug 7, 2024

Describe your changes

Fixing comments and strings.

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@brentstone brentstone mentioned this pull request Aug 7, 2024
2 tasks
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.53%. Comparing base (682d7ff) to head (ae5fda1).
Report is 20 commits behind head on main.

Files Patch % Lines
crates/apps_lib/src/client/rpc.rs 0.00% 3 Missing ⚠️
crates/apps_lib/src/cli.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3589      +/-   ##
==========================================
- Coverage   54.53%   54.53%   -0.01%     
==========================================
  Files         323      323              
  Lines      113879   113880       +1     
==========================================
- Hits        62108    62107       -1     
- Misses      51771    51773       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone force-pushed the brent/misc-improvements branch from d9f0bba to d5d485b Compare August 8, 2024 16:58
@brentstone brentstone marked this pull request as ready for review August 8, 2024 21:48
@brentstone brentstone requested review from batconjurer and Fraccaman and removed request for batconjurer August 8, 2024 21:49
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 9, 2024
mergify bot added a commit that referenced this pull request Aug 9, 2024
mergify bot added a commit that referenced this pull request Aug 9, 2024
@mergify mergify bot merged commit 1a8376e into main Aug 9, 2024
21 of 32 checks passed
@mergify mergify bot deleted the brent/misc-improvements branch August 9, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants