no surprises, windows bing bong #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
added a commit
that referenced
this pull request
Jul 25, 2024
tzemanovic
force-pushed
the
tomas/win-bing-bong
branch
from
f6b826a to
4d3f5a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3553 +/- ##
=======================================
Coverage 53.66% 53.66%
=======================================
Files 322 322
Lines 111871 111871
=======================================
+ Hits 60035 60038 +3
+ Misses 51836 51833 -3 ☔ View full report in Codecov by Sentry. |
Closed
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio refresh |
✅ Pull request refreshed |
Fraccaman
added
merge
Fraccaman
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
use cosmos/ibc-rs#1288 to fix windows build (https://github.com/anoma/namada/actions/runs/10085198034/job/27901001472)
Indicate on which release or other PRs this topic is based on
v0.41.0
Checklist before merging to
draft