Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MASP shielded sync client phase 1 #3498

Merged
merged 4 commits into from
Jul 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
- Implements phase 1 of Issue [\#3385](https://github.com/anoma/namada/issues/3385)
- When fetching notes, connections and related failures should not halt shielded sync. Instead, the process
should be restarted
- If fetching is interrupted, the data fetched should be persisted locally so that progress isn't lost.
- A trait for fetching behavior should be added to provide modularity

([\#3498](https://github.com/anoma/namada/pull/3498))
22 changes: 22 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/apps_lib/src/cli/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use crate::cli::cmds::*;
use crate::client::{rpc, tx, utils};

impl CliApi {
pub async fn handle_client_command<C, IO: Io>(
pub async fn handle_client_command<C, IO: Io + Send + Sync>(
client: Option<C>,
cmd: cli::NamadaClient,
io: IO,
Expand Down
Loading
Loading