-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murisi/expand correct test vectors #3494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. The corresponding Transfers now match these.
…ated for IBC transfer.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3494 +/- ##
==========================================
- Coverage 53.48% 53.36% -0.12%
==========================================
Files 320 320
Lines 110000 110217 +217
==========================================
- Hits 58832 58816 -16
- Misses 51168 51401 +233 ☔ View full report in Codecov by Sentry. |
murisi
force-pushed
the
murisi/expand-correct-test-vectors
branch
from
July 10, 2024 07:38
48207b5
to
24b4fa2
Compare
yito88
approved these changes
Jul 10, 2024
This was referenced Jul 10, 2024
grarco
approved these changes
Jul 10, 2024
Closed
brentstone
added a commit
that referenced
this pull request
Jul 10, 2024
* murisi/expand-correct-test-vectors: Added changelog entry. Augment the IBC Transfer printer with MASP details. Integrate MASP Transactions into the generation of IBC transfers. Augment IBC test vectors with MASP data. Expanded printer to support NFT transfers. Updated the printing of IBC transfers. Added capability to generate NFT transfers. Enable generation of Borsh schema for TxData. Fixed transaction generated for IBC transfer. Now construct Transactions with both shielded and unshielded artifacts. The corresponding Transfers now match these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Expanded the scope of test vector generation and updated outdated components of the relevant code. More specifically, the following changes have been made:
Transaction
s now also contain transparent inputs and outputs (in addition to the existing shielded inputs and outputs). The envelopingTransfer
object now fully corresponds to the containedTransaction
.Tx
schema generator to include the schemas of the contents of theData
section (i.eTransfer
,Bond
, and so on). This will help 3rd party vendors in creating parsers for Namada transactions.Tx
generated for IBC transactions to reflect how it is actually constructed in the Namada client. I.e. theIbcMsgTransfer
is not wrapped inside an IBCAny
object, but is instead directly embedded in theData
section.Indicate on which release or other PRs this topic is based on
Namada v0.40.0.
Checklist before merging to
draft