Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/expand correct test vectors #3494

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Conversation

murisi
Copy link
Collaborator

@murisi murisi commented Jul 9, 2024

Describe your changes

Expanded the scope of test vector generation and updated outdated components of the relevant code. More specifically, the following changes have been made:

  • MASP Transactions now also contain transparent inputs and outputs (in addition to the existing shielded inputs and outputs). The enveloping Transfer object now fully corresponds to the contained Transaction.
  • Expanded the Tx schema generator to include the schemas of the contents of the Data section (i.e Transfer, Bond, and so on). This will help 3rd party vendors in creating parsers for Namada transactions.
  • Adjusted the Tx generated for IBC transactions to reflect how it is actually constructed in the Namada client. I.e. the IbcMsgTransfer is not wrapped inside an IBC Any object, but is instead directly embedded in the Data section.
  • Extended the transaction generator to produce IBC NFT Transfers and extended the transaction test vector printer to be able to print out IBC NFT Transfers.
  • Extended the generation of IBC and NFT Transfers to include MASP actions/aspects and extended the test vector printers of these two transfers to include MASP details in addition to the already displayed IBC details.

Indicate on which release or other PRs this topic is based on

Namada v0.40.0.

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 327 lines in your changes missing coverage. Please review.

Project coverage is 53.36%. Comparing base (8479d38) to head (1e431ea).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/sdk/src/signing.rs 0.00% 271 Missing ⚠️
crates/ibc/src/msg.rs 0.00% 24 Missing ⚠️
crates/token/src/lib.rs 0.00% 14 Missing ⚠️
crates/governance/src/storage/proposal.rs 0.00% 7 Missing ⚠️
crates/sdk/src/lib.rs 0.00% 6 Missing ⚠️
crates/ibc/src/lib.rs 0.00% 2 Missing ⚠️
crates/governance/src/storage/vote.rs 0.00% 1 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 1 Missing ⚠️
crates/tx/src/data/pgf.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3494      +/-   ##
==========================================
- Coverage   53.48%   53.36%   -0.12%     
==========================================
  Files         320      320              
  Lines      110000   110217     +217     
==========================================
- Hits        58832    58816      -16     
- Misses      51168    51401     +233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murisi murisi force-pushed the murisi/expand-correct-test-vectors branch from 48207b5 to 24b4fa2 Compare July 10, 2024 07:38
@murisi murisi marked this pull request as ready for review July 10, 2024 08:32
@murisi murisi requested review from yito88 and grarco July 10, 2024 08:36
@murisi murisi mentioned this pull request Jul 10, 2024
brentstone added a commit that referenced this pull request Jul 10, 2024
* murisi/expand-correct-test-vectors:
  Added changelog entry.
  Augment the IBC Transfer printer with MASP details.
  Integrate MASP Transactions into the generation of IBC transfers.
  Augment IBC test vectors with MASP data.
  Expanded printer to support NFT transfers.
  Updated the printing of IBC transfers.
  Added capability to generate NFT transfers.
  Enable generation of Borsh schema for TxData. Fixed transaction generated for IBC transfer.
  Now construct Transactions with both shielded and unshielded artifacts. The corresponding Transfers now match these.
@brentstone brentstone merged commit cd8f6b4 into main Jul 24, 2024
14 of 19 checks passed
@brentstone brentstone deleted the murisi/expand-correct-test-vectors branch July 24, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants