Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor gov improvements #3471

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Minor gov improvements #3471

merged 8 commits into from
Jul 24, 2024

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Jul 2, 2024

Describe your changes

Minor improvements that include

  • remove remnant gov proposal ID input
  • template gov proposal json files
  • python script to attach wasm code to default proposal

Indicate on which release or other PRs this topic is based on

v0.40.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 53.47%. Comparing base (8479d38) to head (7794f6e).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/node/src/shell/governance.rs 0.00% 13 Missing ⚠️
crates/apps_lib/src/cli.rs 0.00% 2 Missing ⚠️
crates/sdk/src/queries/vp/pgf.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3471      +/-   ##
==========================================
- Coverage   53.48%   53.47%   -0.01%     
==========================================
  Files         320      320              
  Lines      110000   110001       +1     
==========================================
- Hits        58832    58825       -7     
- Misses      51168    51176       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone changed the title Remove gov proposal ID Minor gov improvements Jul 2, 2024
@brentstone brentstone force-pushed the brent/remove-gov-prop-id-input branch from f6a391c to c7b76c5 Compare July 2, 2024 05:44
@brentstone brentstone force-pushed the brent/remove-gov-prop-id-input branch from 1d6c9ca to 290a996 Compare July 11, 2024 18:36
@brentstone brentstone force-pushed the brent/remove-gov-prop-id-input branch from 290a996 to 334f688 Compare July 12, 2024 21:34
@brentstone brentstone mentioned this pull request Jul 16, 2024
@brentstone brentstone marked this pull request as ready for review July 19, 2024 02:40
@brentstone brentstone requested a review from Fraccaman July 19, 2024 02:42
brentstone added a commit that referenced this pull request Jul 19, 2024
* brent/remove-gov-prop-id-input:
  changelog: add #3471
  update template proposals
  aesthetic improvement
  improve logging
  template proposal
  script to attach wasm code to proposal data
  fix clippy
  see what fails
@Fraccaman
Copy link
Member

looks good to me, maybe we could also do #3536 ?

@brentstone brentstone merged commit 37ef045 into main Jul 24, 2024
16 of 19 checks passed
@brentstone brentstone deleted the brent/remove-gov-prop-id-input branch July 24, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants