Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DI - shielded token #3466

Merged
merged 8 commits into from
Jul 30, 2024
Merged

DI - shielded token #3466

merged 8 commits into from
Jul 30, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jun 28, 2024

Describe your changes

Dependency injection for the shielded token - rm'ing cross-system dep on:

  • parameters
  • trans_token

The newly added test crates/systems/src/test.rs ensures that there are no cross-deps between these systems. More to be added as they are refactored.

Indicate on which release or other PRs this topic is based on

Depends-On: #3472

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 83.04498% with 49 lines in your changes missing coverage. Please review.

Project coverage is 54.55%. Comparing base (1154023) to head (0fc23dd).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/token/src/lib.rs 25.00% 18 Missing ⚠️
crates/trans_token/src/lib.rs 76.47% 8 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 5 Missing ⚠️
crates/shielded_token/src/vp.rs 0.00% 5 Missing ⚠️
crates/systems/src/test.rs 82.75% 5 Missing ⚠️
crates/proof_of_stake/src/lib.rs 91.83% 4 Missing ⚠️
crates/ibc/src/lib.rs 0.00% 2 Missing ⚠️
crates/parameters/src/lib.rs 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3466      +/-   ##
==========================================
+ Coverage   54.51%   54.55%   +0.03%     
==========================================
  Files         323      324       +1     
  Lines      113288   113431     +143     
==========================================
+ Hits        61762    61878     +116     
- Misses      51526    51553      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic force-pushed the tomas/di-shielded-token branch 3 times, most recently from 44421be to ecfe104 Compare July 3, 2024 15:34
@tzemanovic tzemanovic marked this pull request as ready for review July 3, 2024 15:51
@tzemanovic tzemanovic requested a review from grarco July 3, 2024 15:52
@tzemanovic tzemanovic mentioned this pull request Jul 3, 2024
4 tasks
@grarco
Copy link
Collaborator

grarco commented Jul 5, 2024

Looks good to me except for the compilation issue with wasm tests

@tzemanovic
Copy link
Member Author

Looks good to me except for the compilation issue with wasm tests

ah, thx I missed this all the way back in the #3402 base

@tzemanovic tzemanovic force-pushed the tomas/di-shielded-token branch from ecfe104 to 061382b Compare July 9, 2024 19:27
tzemanovic added a commit that referenced this pull request Jul 9, 2024
tzemanovic added a commit that referenced this pull request Jul 10, 2024
@tzemanovic tzemanovic force-pushed the tomas/di-shielded-token branch from 49088fa to 0028817 Compare July 10, 2024 08:48
tzemanovic added a commit that referenced this pull request Jul 11, 2024
@tzemanovic tzemanovic force-pushed the tomas/di-shielded-token branch from 0028817 to 7f87875 Compare July 11, 2024 10:19
grarco
grarco previously approved these changes Jul 15, 2024
@tzemanovic tzemanovic mentioned this pull request Jul 29, 2024
tzemanovic added a commit that referenced this pull request Jul 29, 2024
@tzemanovic tzemanovic force-pushed the tomas/di-shielded-token branch from 7f87875 to 4f96b65 Compare July 29, 2024 08:48
@tzemanovic tzemanovic force-pushed the tomas/di-shielded-token branch from 4f96b65 to 0fc23dd Compare July 30, 2024 13:58
Copy link
Contributor

mergify bot commented Jul 30, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

mergify bot added a commit that referenced this pull request Jul 30, 2024
@mergify mergify bot merged commit a7daf2e into main Jul 30, 2024
21 checks passed
@mergify mergify bot deleted the tomas/di-shielded-token branch July 30, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants