-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murisi/generalize vectorized transfers #3446
Conversation
1ebcb5e
to
d15774f
Compare
d15774f
to
29a64eb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3446 +/- ##
==========================================
- Coverage 53.92% 53.88% -0.05%
==========================================
Files 317 317
Lines 107575 107645 +70
==========================================
- Hits 58011 58005 -6
- Misses 49564 49640 +76 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conceptual ACK - much, much cleaner!
token, | ||
amount, | ||
} in data | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note: I think I've improved this in #3393 by trying to group the same sources/tokens before looking for the available notes
6436e48
to
6110726
Compare
Closing in favor of #3459 |
Describe your changes
Attempt to simplify the combination of split MASP transfers and vectorized transfers. The main change is to make a transfer format that allows shielded operations to be done in the presence of both transparent inputs and transparent outputs. All the other transfer formats are then subsumed into this one.
Indicate on which release or other PRs this topic is based on
#3356
Checklist before merging to
draft