Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply snapshot for state sync #3394

Closed
wants to merge 5 commits into from
Closed

Conversation

batconjurer
Copy link
Member

Describe your changes

Addresses the remaining points of Issue #3307

  • Adds chunking logic to snapshots
  • Implements the OfferSnapshot ABCI call
  • Implements the ApplySnapshotChunk ABCI call

Indicate on which release or other PRs this topic is based on

Built on top of #3386

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 49.16944% with 306 lines in your changes missing coverage. Please review.

Project coverage is 53.90%. Comparing base (879a326) to head (b527e65).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/node/src/shell/snapshots.rs 0.00% 177 Missing ⚠️
crates/node/src/shims/abcipp_shim.rs 0.00% 56 Missing ⚠️
crates/node/src/storage/rocksdb.rs 84.24% 49 Missing ⚠️
crates/node/src/lib.rs 0.00% 9 Missing ⚠️
crates/node/src/shims/abcipp_shim_types.rs 0.00% 6 Missing ⚠️
crates/node/src/shell/testing/node.rs 0.00% 4 Missing ⚠️
crates/storage/src/db.rs 0.00% 3 Missing ⚠️
crates/node/src/shell/mod.rs 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3394      +/-   ##
==========================================
- Coverage   53.92%   53.90%   -0.02%     
==========================================
  Files         317      318       +1     
  Lines      107575   108119     +544     
==========================================
+ Hits        58011    58284     +273     
- Misses      49564    49835     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman
Copy link
Member

Field Value
command spawn devnet
template_name 0.39.0
retention_period 2024-06-17T13:00:00Z
epochs_per_year 60000
block_time 5
total_validators 3
faucet off
indexer off

@batconjurer batconjurer force-pushed the bat/feat/apply-snapshots branch from 0031700 to 9f20acc Compare June 12, 2024 08:49
@batconjurer batconjurer force-pushed the bat/feat/apply-snapshots branch from 9f20acc to b527e65 Compare June 13, 2024 08:29
@Fraccaman
Copy link
Member

Field Value
command spawn devnet
template_name 0.39.0
retention_period 2024-06-17T13:00:00Z
epochs_per_year 60000
block_time 5
total_validators 3
faucet off
indexer off

@brentstone
Copy link
Collaborator

what's the status of this PR?

@brentstone brentstone mentioned this pull request Jul 8, 2024
5 tasks
@batconjurer
Copy link
Member Author

what's the status of this PR?

We haven't figured out how to make cometbft actually start using state sync instead of block sync

@sug0 sug0 marked this pull request as draft August 20, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants