cli: use the default configured node addr for shielded sync #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
added a commit
that referenced
this pull request
May 30, 2024
tzemanovic
force-pushed
the
tomas/sync-default-node-addr
branch
from
1dcf353 to
f6809da
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3333 +/- ##
==========================================
- Coverage 54.05% 54.05% -0.01%
==========================================
Files 315 315
Lines 106296 106296
==========================================
- Hits 57461 57455 -6
- Misses 48835 48841 +6 ☔ View full report in Codecov by Sentry. |
batconjurer
approved these changes
May 30, 2024
Closed
brentstone
force-pushed
the
tomas/sync-default-node-addr
branch
from
f6809da to
57216b2
Compare
tzemanovic
added a commit
that referenced
this pull request
May 31, 2024
* origin/tomas/sync-default-node-addr: changelog: add #3333 cli: use the default configured node addr for shielded sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
A tiny change - when the
--nodeis not specified forshielded-synccmd it should default to the address from local configIndicate on which release or other PRs this topic is based on
v0.38.0
Checklist before merging to
draft