-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murisi+grarco/multi tx masp vp rebased2 #3264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sapling bundle anymore
…oves unchecked operation.
murisi
force-pushed
the
murisi+grarco/multi-tx-masp-vp-rebased2
branch
from
May 17, 2024 18:30
a8034ea
to
6bba813
Compare
Namada 0.35.1 is a patch release that fixes a couple build issues with the last minor release.
murisi
force-pushed
the
murisi+grarco/multi-tx-masp-vp-rebased2
branch
from
May 17, 2024 18:45
6bba813
to
75b71b5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3264 +/- ##
==========================================
- Coverage 60.24% 60.12% -0.13%
==========================================
Files 303 302 -1
Lines 93191 93389 +198
==========================================
+ Hits 56145 56147 +2
- Misses 37046 37242 +196 ☔ View full report in Codecov by Sentry. |
2 tasks
murisi
force-pushed
the
murisi+grarco/multi-tx-masp-vp-rebased2
branch
from
May 20, 2024 19:26
c1115c9
to
a892e00
Compare
murisi
added a commit
that referenced
this pull request
May 20, 2024
2 tasks
murisi
force-pushed
the
murisi+grarco/multi-tx-masp-vp-rebased2
branch
from
May 20, 2024 21:12
a892e00
to
96218d8
Compare
brentstone
added a commit
that referenced
this pull request
May 21, 2024
* origin/murisi+grarco/multi-tx-masp-vp-rebased2: Enable governance to change MASP token map. Moved SignedAmount into core and removed use of unchecked arithmetic. Use try_fold to build the ChangedBalances object. Created a structure for representing conversion leafs. Factored the accumulation code out of verify_sapling_balancing_value. Updated the WASM binaries. Extend SignedAmount to hold MASP value balance. Use a MASP crate that guarantees ValueSums. Make MASP VP accept IBC transactions. Ensure that all implied transfers have been authorized by the relevant party. Split validate_transparent_bundle into 3 functions. Now check that the diff between pre and post is the value balance. Now decode AssetTypes separately. Unifies `DeltaBalance` and `SignedAmount` Fix transparent bundle validation bug Fixes balances check in masp vp to allow non-masp transfers Fixes balance owner when token is minted Changelog #2690 Refactors transparent bundle validation into a separate function. Removes unchecked operation. `valid_spend_descriptions_anchor` does not expect the presence of the sapling bundle anymore Refactors balances split Fixes unrecognized assets Refactors transparent bundle check to just compare maps Reworks masp vp to accept multiple transfers in a single tx
murisi
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Tried to increase the readability, strength, and generality of the MASP validity predicate whilst decreasing its verbosity. Closes #3068 . The changes are as follows:
Transaction
inputs and outputs that exceed pre-balances and post-balances respectively are no longer allowed.AssetType
decoding in one place before starting to check the transparent bundlesTransaction
s and unrelatedTransfer
s touching the same addresses/tokensTransaction
s and the balancing transaction are sufficiently authorized; prevents malleabilityWhat would still need to be handled/fixed if this code turns out to be relevant:
Transaction
to Bertha is embeddable inside aTransfer
to Christel only if Bertha has signed the entire transaction (in addition to the usual MASP checks).Indicate on which release or other PRs this topic is based on
Namada 0.35.1
anoma/masp#83
heliaxdev/num-traits#1
Checklist before merging to
draft