split up apps bin and lib crates #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/brent/cleanup-dependencies: changelog: add #3218 respond to comments upgrade tracing-log use updated fork of tiny-hderive use regex workspace de-duplicate itertools by upgrading itself and tonic-build upgrade ed25519-consensus replace dep `parse_duration` with `duration-str` update shlex update rustls update mio update libgit2-sys update h2 update eyre remove unused dependencies
* origin/tiago/dont-export-wasm-mem: Changelog for #3258 Remove unused WASM memory export
* origin/yuji/tendermint-0.36: check event attribute parsing result fix test update masp add changelog for clippy ibc-rs 0.53 bump to tendermint-rs 0.36
* origin/grarco/tx-batch: Restores `batch_size` arg for `fetch` Refactors `dispatch_tx` to return a result Refactors masp events to avoid dynamic attributes Short-circuit atomic batches at the first failure Implements a `get_tx_data` method on `Ctx` Refactors validity booleans into a `ValidityFlags` struct Refactors buckets in write log with iterator chains Misc refactors, fixes typo Improves unit tests for batches Refactors match on inner tx result Preserve txs order when constructing batch in the sdk Drops duplicated events for errored batch More unit tests for tx batching Appends inner tx result even in case of out of gas Better handling of batch errors Restores shielded sync struct in the sdk Reverts wrong shielded sync cli changes Removes broken batch section optimization Extracts ok tx result evaluation to a separate function Changes error code for batches. Fixes missing events Refactors `evaluate_tx_result`. Updates stats Renames `TxInfo` and fixes write log commit in `finalize_block` Refactors stats accounting Reverts `TryFrom` impls for ethereum data to `Tx` Changelog #1356 Adds unit tests for tx batches Updates tx types comparisons and avoid duplicated signatures for batches Updates error message in ibc test Fixes bug in wrapper keys Fixes fee payemnt logic and unit tests Recomputes signatures for localnet genesis Clippy fix Removes unused `Ciphertext` section Updates `add_inner_tx` to avoid duplicated sections Adds new `mk_tx_batch` for unit testing Fixes tx interface to attach a new inner tx Updates comments Adds an SDK function to construct tx batches Renames `Commitments` and update docs Refactors the batch write log Refactors tx result handling in `finalize_block` Removes custom borsh impls for `BatchedTx` and `BatchedTxRef` More refactoring Misc refactoring Fixes benchmarks Fixes integration tests Fixes wasm tests Refactors test envs Fixes serialization of tx result and unit tests Rebuilds wasm for tests Recomputes genesis signatures. Fixes missing commitments in tests Updates `VpEval` Fixes wasm for test. Clippy + fmt Updates wasm interface and codes Renames batched txs structs Misc updates to write log. Updates tx result handling in `finalize_block` Updates `WriteLog` to support tx batches Improves handling of txs' results in `dispatch_tx` and `finalize_block` Introduces `OwnedBatchedTx` for benchmarks. Fixes benches and tests Generic `TxResult` Updates contexts for batched transactions. Misc updates to protocol Updates logs and tx result to support batching Adds `BatchedTx` struct and updated the native vps and transactions execution Updates core tx methods and masp client functions Adds multiple tx commitments in `Header`
* origin/grarco/masp-fees: Changelog #3217 Assigns issues to TODOs Removes `wrapper_changed_keys` from `TxResult` Removes fee unshielding e2e test Removes fee unshielding integration tests Recomputes tx test fixture Recomputes wasm for tests modules Updates TODO comments Reworks sdk fee validation Renames `wrapper_fee_check` Removes error/functions related to fee unshielding Removes `descriptions_limit` protocol param Removes redundandt wrapper types Removes fee unshielding cli and tx args Removes `unshield_section_hash` from `WrapperTx`. Updates the relative functions. Removes event for masp wrapper tx
tzemanovic
force-pushed
the
tomas/split-up-apps
branch
from
8ddd536 to
b132a3a
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
relates to #2111
There are advantages in not mixing lib and bin code in a single crate so this PR is splitting these up. This PR adds a new
crates/apps_libwith the library code split up fromcrates/appsIndicate on which release or other PRs this topic is based on
draft
diff: https://github.com/anoma/namada/pull/3259/files/b0321a51246b6558450d670c07e9315275a76ab1..b132a3a30da1b60d61d1ed981408b363cb06244b
Checklist before merging to
draft