Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't send reveal PK tx on txs with --force #3245

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented May 14, 2024

Describe your changes

closes #2919

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic changed the title sdk/tx: don't send reveal PK tx on txs with --force don't send reveal PK tx on txs with --force May 14, 2024
@tzemanovic tzemanovic marked this pull request as ready for review May 14, 2024 19:10
@tzemanovic tzemanovic requested a review from brentstone May 14, 2024 19:10
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 59.40%. Comparing base (9d4de02) to head (c7ba64b).
Report is 268 commits behind head on main.

Files Patch % Lines
crates/sdk/src/tx.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3245   +/-   ##
=======================================
  Coverage   59.40%   59.40%           
=======================================
  Files         298      298           
  Lines       92326    92325    -1     
=======================================
  Hits        54849    54849           
+ Misses      37477    37476    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tzemanovic added a commit that referenced this pull request May 21, 2024
* tomas/no-reveal-on-force:
  changelog: add #3245
  sdk/tx: don't send reveal PK tx on txs with `--force`
tzemanovic added a commit that referenced this pull request May 21, 2024
* tomas/no-reveal-on-force:
  changelog: add #3245
  sdk/tx: don't send reveal PK tx on txs with `--force`
@tzemanovic tzemanovic merged commit 30a52e8 into main May 21, 2024
17 of 19 checks passed
@tzemanovic tzemanovic deleted the tomas/no-reveal-on-force branch May 21, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--force adds a reveal public key transaction that always fails
2 participants