namada/wasm/cache: write the file to cache before updating progress #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3181 +/- ##
==========================================
- Coverage 59.40% 59.40% -0.01%
==========================================
Files 298 298
Lines 92326 92329 +3
==========================================
- Hits 54849 54848 -1
- Misses 37477 37481 +4 ☔ View full report in Codecov by Sentry. |
Fraccaman
approved these changes
May 7, 2024
Fraccaman
pushed a commit
that referenced
this pull request
May 7, 2024
brentstone
added a commit
that referenced
this pull request
May 8, 2024
* origin/tomas/fix-wasm-cache-pre-compile: changelog: add #3181 namada/wasm/cache: write the file to cache before updating progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Indicate on which release or other PRs this topic is based on
v0.34.0
Checklist before merging to
draft