Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set height for abci_query #3164

Merged
merged 3 commits into from
May 9, 2024
Merged

Set height for abci_query #3164

merged 3 commits into from
May 9, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented May 2, 2024 •
edited
Loading

Describe your changes

closes #3065

Indicate on which release or other PRs this topic is based on

v0.34.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@yito88 yito88 requested a review from grarco May 2, 2024 15:41
@brentstone brentstone mentioned this pull request May 2, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented May 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 59.41%. Comparing base (9d4de02) to head (801a115).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/apps/src/lib/node/ledger/shell/queries.rs 0.00% 6 Missing ⚠️
crates/sdk/src/queries/mod.rs 0.00% 1 Missing ⚠️
crates/sdk/src/queries/shell.rs 90.00% 1 Missing ⚠️
crates/sdk/src/queries/shell/eth_bridge.rs 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3164   +/-   ##
=======================================
  Coverage   59.40%   59.41%           
=======================================
  Files         298      298           
  Lines       92326    92336   +10     
=======================================
+ Hits        54849    54861   +12     
+ Misses      37477    37475    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grarco
grarco approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

brentstone added a commit that referenced this pull request May 2, 2024
@brentstone
Merge branch 'yuji/abci-query-height' (#3164)
020393c 
* yuji/abci-query-height:
  add changelog
  set height for abci_query
brentstone added a commit that referenced this pull request May 8, 2024
@brentstone
Merge branch 'yuji/abci-query-height' (#3164)
50ae0ef 
* origin/yuji/abci-query-height:
  fix queried height
  add changelog
  set height for abci_query
@brentstone brentstone merged commit 9cbd7a4 into main May 9, 2024
18 of 19 checks passed
@brentstone brentstone deleted the yuji/abci-query-height branch May 9, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grarco grarco grarco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixed height in abci_query response
3 participants
@yito88 @grarco @brentstone