More client side checks #3154
Merged
More client side checks #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraccaman
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3154 +/- ##
==========================================
- Coverage 59.41% 59.38% -0.04%
==========================================
Files 298 298
Lines 92326 92372 +46
==========================================
- Hits 54853 54851 -2
- Misses 37473 37521 +48 ☔ View full report in Codecov by Sentry. |
2 tasks
brentstone
previously approved these changes
May 1, 2024
brentstone
added a commit
that referenced
this pull request
May 1, 2024
* fraccaman/minor-cli-fixe4s: some improvements added init account, update account and steward commission cli checks
brentstone
added a commit
that referenced
this pull request
May 1, 2024
* fraccaman/minor-cli-fixe4s: bug fix: handle empty public keys correctly some improvements added init account, update account and steward commission cli checks
brentstone
approved these changes
May 1, 2024
brentstone
added a commit
that referenced
this pull request
May 8, 2024
* origin/fraccaman/minor-cli-fixe4s: changelog: add #3154 bug fix: handle empty public keys correctly some improvements added init account, update account and steward commission cli checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2671 and supersedes #2747
Closes #2807
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft