state/write_log: refactor temp key-vals for better type-safety #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3110 +/- ##
=======================================
Coverage 59.39% 59.40%
=======================================
Files 298 298
Lines 92771 92717 -54
=======================================
- Hits 55104 55077 -27
+ Misses 37667 37640 -27 ☔ View full report in Codecov by Sentry. |
Closed
grarco
reviewed
Apr 23, 2024
grarco
previously approved these changes
Apr 23, 2024
|
let me know if this is rdy for merge or will have another change |
tzemanovic
added a commit
that referenced
this pull request
Apr 24, 2024
tzemanovic
force-pushed
the
tomas/write-log-t-safety
branch
from
791d172 to
8ca77c8
Compare
should be good to go now |
grarco
previously approved these changes
Apr 24, 2024
tzemanovic
force-pushed
the
tomas/write-log-t-safety
branch
from
172ba75 to
db5f425
Compare
brentstone
added a commit
that referenced
this pull request
Apr 25, 2024
* tomas/write-log-t-safety: changelog: add #3110 state/write_log: refactor temp key-vals for better type-safety
brentstone
added a commit
that referenced
this pull request
Apr 25, 2024
* tomas/write-log-t-safety: changelog: add #3110 state/write_log: refactor temp key-vals for better type-safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #2915
Indicate on which release or other PRs this topic is based on
v0.33.0
Checklist before merging to
draft