Remove Epoch from WrapperTx #2946

cpp-phoenix · 2024-03-22T18:10:02Z

Describe your changes

Closes #2691

Indicate on which release or other PRs this topic is based on

v0.34.0

Checklist before merging to `draft`

I have added a changelog
Git history is in acceptable state

codecov · 2024-03-22T18:34:03Z

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 59.39%. Comparing base (ea843f7) to head (1572234).
Report is 7 commits behind head on main.

❗ Current head 1572234 differs from pull request most recent head 90e6cb2. Consider uploading reports for the commit 90e6cb2 to get more accurate results

Files	Patch %	Lines
crates/light_sdk/src/transaction/pos.rs	0.00%	7 Missing ⚠️
crates/light_sdk/src/transaction/account.rs	0.00%	3 Missing ⚠️
crates/light_sdk/src/transaction/governance.rs	0.00%	2 Missing ⚠️
crates/light_sdk/src/transaction/pgf.rs	0.00%	2 Missing ⚠️
crates/sdk/src/tx.rs	0.00%	2 Missing ⚠️
crates/light_sdk/src/transaction/bridge.rs	0.00%	1 Missing ⚠️
crates/light_sdk/src/transaction/ibc.rs	0.00%	1 Missing ⚠️
crates/light_sdk/src/transaction/transfer.rs	0.00%	1 Missing ⚠️
crates/sdk/src/masp.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2946      +/-   ##
==========================================
- Coverage   59.41%   59.39%   -0.02%     
==========================================
  Files         298      298              
  Lines       92326    92690     +364     
==========================================
+ Hits        54853    55057     +204     
- Misses      37473    37633     +160

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

batconjurer

Couple of small things, and it obviously needs a rebase. Otherwise looks good.

crates/light_sdk/src/transaction/mod.rs

batconjurer · 2024-04-15T08:57:43Z

crates/sdk/src/tx.rs

@@ -183,17 +183,15 @@ pub fn dump_tx<IO: Io>(io: &IO, args: &args::Tx, tx: Tx) {
 /// to it.
 #[allow(clippy::too_many_arguments)]
 pub async fn prepare_tx<C: crate::queries::Client + Sync>(
-    client: &C,
+    _client: &C,


this argument should also be removed

I don't know why this comment was marked as resolved. I would still like to have this argument removed. Especially since it removes the need for the generic, which should simplify other parts of the code base.

Fraccaman · 2024-04-22T09:06:12Z

@cpp-phoenix thanks for ur PR! Do u think u can think the issues in the code review and rebase on base ?

crates/sdk/src/masp.rs

yito88 · 2024-04-25T14:53:14Z

We need to update Hermes with this change. E2E tests should pass with https://github.com/heliaxdev/hermes/tree/1.7.4-namada-2946.

batconjurer · 2024-04-26T08:23:52Z

crates/sdk/src/tx.rs

@@ -183,17 +183,15 @@ pub fn dump_tx<IO: Io>(io: &IO, args: &args::Tx, tx: Tx) {
 /// to it.
 #[allow(clippy::too_many_arguments)]
 pub async fn prepare_tx<C: crate::queries::Client + Sync>(
-    client: &C,
+    _client: &C,


I don't know why this comment was marked as resolved. I would still like to have this argument removed. Especially since it removes the need for the generic, which should simplify other parts of the code base.

brentstone · 2024-04-26T16:02:28Z

@batconjurer thx, I resolved the conversation because I thought I had remove the _client but somehow it slipped through again. Thanks for the note!

* cpp-phoenix/cpp-phoenix/remove-epoch-from-wrappertx: changelog: add #2946 rebuild wasms for tests impl fix from review comment refactor: remove Epoch from WrapperTx

…om-wrappertx' into brent/draft+2946+3100 * cpp-phoenix/cpp-phoenix/remove-epoch-from-wrappertx: changelog: add #2946 rebuild wasms for tests impl fix from review comment refactor: remove Epoch from WrapperTx

* cpp-phoenix/cpp-phoenix/remove-epoch-from-wrappertx: changelog: add #2946 rebuild wasms for tests impl fix from review comment refactor: remove Epoch from WrapperTx

grarco requested review from grarco and batconjurer April 11, 2024 10:21

batconjurer requested changes Apr 15, 2024

View reviewed changes

Fraccaman mentioned this pull request Apr 15, 2024

Draft #3079

Closed

brentstone force-pushed the cpp-phoenix/remove-epoch-from-wrappertx branch from d422dae to 246be23 Compare April 24, 2024 05:40

brentstone requested a review from batconjurer April 24, 2024 05:42

brentstone force-pushed the cpp-phoenix/remove-epoch-from-wrappertx branch from 246be23 to 1b80cff Compare April 24, 2024 06:03

grarco reviewed Apr 24, 2024

View reviewed changes

crates/sdk/src/masp.rs Show resolved Hide resolved

brentstone added the ready for draft label Apr 25, 2024

brentstone added a commit to cpp-phoenix/namada that referenced this pull request Apr 25, 2024

changelog: add anoma#2946

8f2565d

batconjurer requested changes Apr 26, 2024

View reviewed changes

brentstone added a commit to cpp-phoenix/namada that referenced this pull request Apr 26, 2024

changelog: add anoma#2946

05b2c93

brentstone force-pushed the cpp-phoenix/remove-epoch-from-wrappertx branch from 8f2565d to 05b2c93 Compare April 26, 2024 16:09

brentstone added a commit to cpp-phoenix/namada that referenced this pull request Apr 26, 2024

changelog: add anoma#2946

1572234

brentstone force-pushed the cpp-phoenix/remove-epoch-from-wrappertx branch from 05b2c93 to 1572234 Compare April 26, 2024 17:18

brentstone added a commit that referenced this pull request Apr 26, 2024

fixup! Merge branch 'cpp-phoenix/remove-epoch-from-wrappertx' (#2946)

22a5865

brentstone mentioned this pull request Apr 27, 2024

Draft - released 0.35.0 #3147

Closed

brentstone force-pushed the cpp-phoenix/remove-epoch-from-wrappertx branch from 1572234 to 7ac1bf3 Compare April 27, 2024 01:39

brentstone added a commit to cpp-phoenix/namada that referenced this pull request Apr 27, 2024

changelog: add anoma#2946

7ac1bf3

cpp-phoenix and others added 2 commits April 26, 2024 19:14

refactor: remove Epoch from WrapperTx

17634a9

impl fix from review comment

03d4c65

brentstone added a commit to cpp-phoenix/namada that referenced this pull request Apr 27, 2024

changelog: add anoma#2946

e820bb5

brentstone force-pushed the cpp-phoenix/remove-epoch-from-wrappertx branch from 7ac1bf3 to e820bb5 Compare April 27, 2024 02:14

brentstone added 2 commits April 26, 2024 19:18

rebuild wasms for tests

43fdede

changelog: add anoma#2946

90e6cb2

brentstone force-pushed the cpp-phoenix/remove-epoch-from-wrappertx branch from e820bb5 to 90e6cb2 Compare April 27, 2024 02:18

Fraccaman pushed a commit that referenced this pull request Apr 30, 2024

Merge branch 'cpp-phoenix/remove-epoch-from-wrappertx' (#2946)

55dc816

brentstone added the merged to draft label Apr 30, 2024

brentstone added a commit that referenced this pull request May 8, 2024

fixup! Merge branch 'cpp-phoenix/remove-epoch-from-wrappertx' (#2946)

5712f2c

brentstone merged commit a59bf7d into anoma:main May 9, 2024
11 of 17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Epoch from WrapperTx #2946

Remove Epoch from WrapperTx #2946

cpp-phoenix commented Mar 22, 2024 •

edited by brentstone

Loading

codecov bot commented Mar 22, 2024 •

edited

Loading

batconjurer left a comment

batconjurer Apr 15, 2024

batconjurer Apr 26, 2024

Fraccaman commented Apr 22, 2024

yito88 commented Apr 25, 2024

batconjurer Apr 26, 2024

brentstone commented Apr 26, 2024

Remove Epoch from WrapperTx #2946

Remove Epoch from WrapperTx #2946

Conversation

cpp-phoenix commented Mar 22, 2024 • edited by brentstone Loading

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

codecov bot commented Mar 22, 2024 • edited Loading

Codecov Report

batconjurer left a comment

Choose a reason for hiding this comment

batconjurer Apr 15, 2024

Choose a reason for hiding this comment

batconjurer Apr 26, 2024

Choose a reason for hiding this comment

Fraccaman commented Apr 22, 2024

yito88 commented Apr 25, 2024

batconjurer Apr 26, 2024

Choose a reason for hiding this comment

brentstone commented Apr 26, 2024

cpp-phoenix commented Mar 22, 2024 •

edited by brentstone

Loading

Checklist before merging to `draft`

codecov bot commented Mar 22, 2024 •

edited

Loading