Fix client bug preventing a validator with no self-bonds from voting in governance #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2877 +/- ##
==========================================
+ Coverage 53.44% 55.15% +1.70%
==========================================
Files 310 309 -1
Lines 101574 102694 +1120
==========================================
+ Hits 54288 56638 +2350
+ Misses 47286 46056 -1230 ☔ View full report in Codecov by Sentry. |
Fraccaman
previously approved these changes
Mar 11, 2024
Fraccaman
reviewed
Mar 11, 2024
crates/sdk/src/tx.rs
Outdated
| )); | ||
| } | ||
| let delegations = if is_validator { | ||
| let current_epoch = query_epoch(context.client()).await?; |
There was a problem hiding this comment.
dont need to query for the epoch, can you the one from received in the parameters
There was a problem hiding this comment.
ah thx, missed that
brentstone
added a commit
that referenced
this pull request
Mar 15, 2024
brentstone
force-pushed
the
brent/fix-val-voting-no-self-bonds
branch
from
6d94e5d to
e6149fa
Compare
brentstone
added a commit
that referenced
this pull request
Mar 15, 2024
brentstone
force-pushed
the
brent/fix-val-voting-no-self-bonds
branch
from
e6149fa to
c1cab03
Compare
This was referenced Mar 15, 2024
brentstone
added a commit
that referenced
this pull request
Mar 19, 2024
brentstone
force-pushed
the
brent/fix-val-voting-no-self-bonds
branch
from
c1cab03 to
7278b50
Compare
brentstone
force-pushed
the
brent/fix-val-voting-no-self-bonds
branch
from
7278b50 to
5c0fbeb
Compare
tzemanovic
added a commit
that referenced
this pull request
Apr 1, 2024
* origin/brent/fix-val-voting-no-self-bonds: fmt fix rebase remove unnecessary epoch query changelog: add #2877 fix client bug preventing a validator with no self-bonds from voting fmt changelog: add #2803 fmt + clippy more tests added unit tests fix governance vp remove offline governance, refactor tally types
2 tasks
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/brent/fix-val-voting-no-self-bonds: fmt fix rebase remove unnecessary epoch query changelog: add #2877 fix client bug preventing a validator with no self-bonds from voting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2865. The client was preventing a validator that has delegations but no self-bonds from submitting a governance proposal vote tx. Now fixed.
Indicate on which release or other PRs this topic is based on
Based on #2803, which is based on v0.32.0.
Checklist before merging to
draft