Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear ibc events on rejected txs #2850

Merged
2 commits merged into from
Mar 19, 2024
Merged

Clear ibc events on rejected txs #2850

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42aa4f5
state/write_log: clear IBC events in `fn drop_tx`
tzemanovic Mar 7, 2024
49a6bd8
changelog: add #2850
tzemanovic Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/state/src/write_log.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,12 +473,13 @@ impl WriteLog {
self.take_ibc_events();
}

/// Drop the current transaction's write log and precommit when it's
/// declined by any of the triggered validity predicates. Starts a new
/// transaction write log.
/// Drop the current transaction's write log and IBC events and precommit
/// when it's declined by any of the triggered validity predicates.
/// Starts a new transaction write log.
pub fn drop_tx(&mut self) {
self.tx_precommit_write_log.clear();
self.tx_write_log.clear();
self.ibc_events.clear();
}

/// Drop the current transaction's write log but keep the precommit one.
Expand Down
Loading