Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a pattern matching iterator to the DB #2839

Merged
16 commits merged into from
Mar 19, 2024
Merged

Added a pattern matching iterator to the DB #2839

16 commits merged into from
Mar 19, 2024

Conversation

batconjurer
Copy link
Member

Describe your changes

When iterating over key prefixes, we can additionally filter out keys based on a regex.

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@batconjurer batconjurer mentioned this pull request Mar 7, 2024
2 tasks
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 216 lines in your changes are missing coverage. Please review.

Project coverage is 53.82%. Comparing base (cc3edde) to head (1242c11).

Files Patch % Lines
crates/apps/src/lib/node/ledger/storage/rocksdb.rs 0.00% 44 Missing ⚠️
crates/governance/src/cli/onchain.rs 0.00% 24 Missing ⚠️
crates/storage/src/mockdb.rs 0.00% 24 Missing ⚠️
crates/macros/src/lib.rs 71.60% 23 Missing ⚠️
crates/proof_of_stake/src/types/mod.rs 0.00% 13 Missing ⚠️
crates/storage/src/types.rs 0.00% 10 Missing ⚠️
crates/governance/src/cli/offline.rs 0.00% 9 Missing ⚠️
crates/apps/src/lib/config/genesis.rs 0.00% 7 Missing ⚠️
crates/core/src/event.rs 0.00% 6 Missing ⚠️
crates/migrations/src/lib.rs 0.00% 5 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2839      +/-   ##
==========================================
- Coverage   53.88%   53.82%   -0.06%     
==========================================
  Files         308      309       +1     
  Lines      100154   100393     +239     
==========================================
+ Hits        53967    54036      +69     
- Misses      46187    46357     +170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tzemanovic added a commit that referenced this pull request Mar 8, 2024
* bat/feat/iter-pattern:
  [chore]: Added changelog
  [feat]: Added a pattern matching iterator to the db
@brentstone brentstone mentioned this pull request Mar 8, 2024
@batconjurer batconjurer force-pushed the bat/feat/iter-pattern branch 2 times, most recently from 984baf7 to eec70a6 Compare March 8, 2024 10:07
@brentstone brentstone force-pushed the bat/feat/iter-pattern branch from eec70a6 to 1242c11 Compare March 8, 2024 18:32
brentstone added a commit that referenced this pull request Mar 8, 2024
* bat/feat/iter-pattern:
  fmt
  [chore]: Added changelog
  [feat]: Added a pattern matching iterator to the db
brentstone added a commit that referenced this pull request Mar 9, 2024
* origin/bat/feat/iter-pattern:
  fmt
  [chore]: Added changelog
  [feat]: Added a pattern matching iterator to the db
brentstone added a commit that referenced this pull request Mar 18, 2024
* origin/bat/feat/iter-pattern:
  fmt
  [chore]: Added changelog
  [feat]: Added a pattern matching iterator to the db
brentstone added a commit that referenced this pull request Mar 18, 2024
* origin/bat/feat/iter-pattern:
  fmt
  [chore]: Added changelog
  [feat]: Added a pattern matching iterator to the db
@brentstone brentstone closed this pull request by merging all changes into main in 5e0b162 Mar 19, 2024
@brentstone brentstone deleted the bat/feat/iter-pattern branch March 19, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants