Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wasm build #2795

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Improve wasm build #2795

merged 3 commits into from
Apr 12, 2024

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Mar 4, 2024

Describe your changes

WASM build time is improved by putting each wasm tx in its own sub-crate rather than making each one a feature.

Indicate on which release or other PRs this topic is based on

v0.32.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@brentstone brentstone changed the title improve wasm build Improve wasm build Mar 4, 2024
@brentstone brentstone added the wasm label Mar 4, 2024
@Fraccaman Fraccaman self-requested a review March 4, 2024 15:31
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.44%. Comparing base (61a0759) to head (e4da626).
Report is 8 commits behind head on main.

❗ Current head e4da626 differs from pull request most recent head f3dbb47. Consider uploading reports for the commit f3dbb47 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2795   +/-   ##
=======================================
  Coverage   53.44%   53.44%           
=======================================
  Files         310      310           
  Lines      101574   101574           
=======================================
+ Hits        54288    54289    +1     
+ Misses      47286    47285    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fraccaman
Fraccaman previously approved these changes Apr 5, 2024
@Fraccaman Fraccaman marked this pull request as ready for review April 5, 2024 10:10
wasm/Cargo.toml Outdated Show resolved Hide resolved
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/brent/improve-wasm-build:
  changelog: add #2795
  script/release: update wasm_for_tests path
  improve wasm build
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/brent/improve-wasm-build:
  changelog: add #2795
  script/release: update wasm_for_tests path
  improve wasm build
tzemanovic added a commit that referenced this pull request Apr 10, 2024
* origin/brent/improve-wasm-build:
  changelog: add #2795
  script/release: update wasm_for_tests path
  improve wasm build
tzemanovic added a commit that referenced this pull request Apr 11, 2024
* origin/brent/improve-wasm-build:
  changelog: add #2795
  script/release: update wasm_for_tests path
  improve wasm build
tzemanovic added a commit that referenced this pull request Apr 11, 2024
* origin/brent/improve-wasm-build:
  changelog: add #2795
  script/release: update wasm_for_tests path
  improve wasm build
@tzemanovic tzemanovic merged commit 208faeb into main Apr 12, 2024
15 of 17 checks passed
@tzemanovic tzemanovic deleted the brent/improve-wasm-build branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants