Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce baseline types required to implement validator set updates #273
Introduce baseline types required to implement validator set updates #273
Changes from 44 commits
d6d0433
8eb6e03
2dec131
a30cf4f
e060784
0732bb8
a46cce1
b6a3c5d
61030d8
26ab743
27016cd
16c4d4f
32b002e
ce38f19
c14c8f2
944f8c2
791cce8
768eec1
8305590
b0ff8a5
52b6d57
5abd8e7
dc02085
20499f5
4f205f5
dfa21a9
9e1e32d
d904238
a8ae428
9e473ef
e09944c
20cba91
6bb7b41
4a78619
adb9c8e
d0381ab
afc35d7
69c4fb5
a5a2cde
d72e25e
6e4a437
c7f940f
0e13722
3ee213d
01d0423
445bbfd
3f440f9
97021f8
6b442ca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be good if we could bound
S
here (if it's possible?) so that it's impossible to construct aSigned
with an invalid tag, something likeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already tighten
Signed
at the impl block starting on line 148. you can only verify signatures ofSigned
instances with a tag which implementsSignedSerialize
. you can't use the struct itself to instantiate new values, since it has a private field, but you can useSigned::new_from
instead. regardless, we hit the same wall, this instance can't do jack ifS
does not implementSignedSerialize
.tl;dr I don't think this is an issue