BugFix: Adding Client side check For Requiring threshold < Noof public keys in update-account
#2677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Client side check For Requiring threshold < Noof public keys in
update-account
cli call.Describe your changes
Throwing a panic error if condition isn't met so the user accidentally doesn't end up changing threshold to be above the number of public keys. This addresses the existing issue #2624 where the user was able to change threshold to be greater than number of public keys and that caused the wallet to become unusable.
Currently only added the check in
update-account
, as that is mainly used to update the threshold value.Also minor grammatical error corrections to correctly use "than" instead of "then"
Indicate on which release or other PRs this topic is based on
Based on the Bug pointed out in #2624
Checklist before merging to
draft