Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slashed bonds/unbonds info to the client #2670

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Conversation

Krewedk0
Copy link
Contributor

@Krewedk0 Krewedk0 commented Feb 20, 2024

Describe your changes

This PR adds info about slashed bonds/unbonds and changes wording around active bonds (slashed -> slashable) in bonds client request.
Currently slashed amounts are not being reported which confused validators who got slashed during SE.
This is how output of namadac bonds looks like using this PR:
image

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@Krewedk0
Copy link
Contributor Author

Fixed according to review, but slashed amounts are printed w/o a decimal point now
image

@Fraccaman
Copy link
Member

Fixed according to review, but slashed amounts are printed w/o a decimal point now

you should keep the .native_to_string()

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 52.98%. Comparing base (412accd) to head (b683589).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/apps/src/lib/client/rpc.rs 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2670      +/-   ##
==========================================
- Coverage   52.98%   52.98%   -0.01%     
==========================================
  Files         303      303              
  Lines      104166   104180      +14     
==========================================
+ Hits        55194    55197       +3     
- Misses      48972    48983      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Krewedk0
Copy link
Contributor Author

fixed

@Fraccaman
Copy link
Member

there is one e2e failing, if you could please look at it: cargo +nightly-2023-06-01 test e2e::ledger_tests::test_bond_queries -- --test-threads=1 --nocapture --exact

Fraccaman pushed a commit that referenced this pull request Feb 20, 2024
* Krewedk0/main:
  fix ledger test
  fix formatting
  review fix, add changelog
  add slashed bonds/unbonds info to the client
tzemanovic added a commit that referenced this pull request Feb 26, 2024
* Krewedk0/main:
  fix ledger test
  fix formatting
  review fix, add changelog
  add slashed bonds/unbonds info to the client
@tzemanovic tzemanovic merged commit 3925750 into anoma:main Feb 27, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants