Murisi/test vectors 0.30.2 rev 1 #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(none) for empty values. Simplifies hardware wallets.
…ardware wallet implementations.
tzemanovic
added a commit
that referenced
this pull request
Feb 27, 2024
* origin/murisi/test-vectors-0.31.6: Limit commitment sizes. Added a changelog entry. Deduplicated the arbitrary memo generation code. Test vector generator now produces arbitrary signed transactions. Now generate arbitrary PGF IBC targets in the test vectors. Order the test vvectors for init proposal and use the NAM prefix. Give more detailed test vectors for Init Proposal transactions. Start generating arbitrary memos and print them out in the test vectors. Print out the section hashes in the debug vectors. Separated the validators from the commission rates in order to ease hardware wallet implementations. Make sure that generated metadata is always non-empty. Stop printing (none) for empty values. Simplifies hardware wallets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Various changes in order to increase the detail presented in test vectors, increase the variety of test vectors, and ease the implementation of hardware wallet apps. Specifically the changes are as follows:
Indicate on which release or other PRs this topic is based on
Namada v0.30.2
Checklist before merging to
draft