Fix query of protocol params #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent/fix-query-protocol-parameters
branch
from
7be5724 to
d1d00d9
Compare
brentstone
added a commit
that referenced
this pull request
Feb 8, 2024
* brent/fix-query-protocol-parameters: changelog: add #2558 fix query of protocol params
Closed
tzemanovic
reviewed
Feb 9, 2024
| @@ -1538,15 +1538,33 @@ pub async fn query_protocol_parameters( | |||
| let pos_params = query_pos_parameters(context.client()).await; | |||
There was a problem hiding this comment.
a small improvement - we could use let PosParams { } = query ... syntax to destruct the fields to make sure we're using all so if new one is added we don't miss it here
tzemanovic
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Several PoS params were missing from this query, and the general output is reformatted to look nicer as well.
Indicate on which release or other PRs this topic is based on
v0.31.2
Checklist before merging to
draft