Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implemented the random generation of MASP test vectors and slightly altered MASP-related transaction sections to facilitate the printing of shielded amounts with correct denominations. More specifically, the changes are as follows:
TxProver
to aid constructing these transactions with the following properties:LocalTxProver
since it does not generate any zero-knowledge proofsMockTxProver
since it generates binding signatures that the hardware wallet will checkAssetType
derivation to be parameterized by a token'stoken::Denomination
MaspTxBuilder
supplied to hardware wallets to includetoken::Denomination
in the preimagesIndicate on which release or other PRs this topic is based on
#2371
Checklist before merging to
draft