Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix governance tally #2415

Merged
merged 6 commits into from
Jan 26, 2024
Merged

Fix governance tally #2415

merged 6 commits into from
Jan 26, 2024

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Jan 17, 2024 •
edited by tzemanovic
Loading

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@Fraccaman Fraccaman mentioned this pull request Jan 17, 2024
Closed
@Fraccaman Fraccaman force-pushed the fraccaman+tomas/governance-tally branch from 4f61252 to 6d6e158 Compare January 22, 2024 10:21
@Fraccaman Fraccaman requested a review from grarco January 22, 2024 10:21
@Fraccaman Fraccaman marked this pull request as ready for review January 22, 2024 10:21
@Fraccaman Fraccaman requested a review from cwgoes January 22, 2024 10:21
@Fraccaman
Copy link
Member Author

Fraccaman commented Jan 22, 2024 •
edited
Loading

in 90fe551 I disabled a eth oracle test as it was timing out CI way to many times.

@Fraccaman Fraccaman force-pushed the fraccaman+tomas/governance-tally branch from 6d6e158 to 8abb1a5 Compare January 22, 2024 10:30
grarco
grarco previously approved these changes Jan 22, 2024
View reviewed changes
@Fraccaman Fraccaman force-pushed the fraccaman+tomas/governance-tally branch from 8abb1a5 to bedc1d8 Compare January 22, 2024 15:26
cwgoes
cwgoes previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new tally calculations look correct to me. I have not reviewed all of the tests.

tzemanovic added a commit that referenced this pull request Jan 22, 2024
@tzemanovic
Merge branch 'fraccaman+tomas/governance-tally' (#2415)
b41a238 
* origin/fraccaman+tomas/governance-tally:
  fix two third over two third nay
  minor refactor governance
  disable eth oracle test
  minor fixes
  governance tally fix, added some tests
This was referenced Jan 23, 2024
Merged
Closed
@tzemanovic tzemanovic mentioned this pull request Jan 25, 2024
Closed
@tzemanovic tzemanovic merged commit 8bf2360 into main Jan 26, 2024
14 of 15 checks passed
@tzemanovic tzemanovic deleted the fraccaman+tomas/governance-tally branch January 26, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grarco grarco grarco left review comments

@cwgoes cwgoes cwgoes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fraccaman @cwgoes @grarco @tzemanovic